Skip to content

8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file #4016

wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 5, 2025 •
edited by openjdk bot
Loading

I backport this to simplify later changes.

Backport is based on push to 21.
Skipped some more files, needed further resolves:

test/jdk/tools/jpackage/linux/ReleaseTest.java
Resolved @test block

test/jdk/tools/jpackage/macosx/SigningAppImageTest.java
test/jdk/tools/jpackage/macosx/SigningPackageTest.java
Copyright

test/jdk/tools/jpackage/share/AddLauncherTest.java
Resolved @test block

test/jdk/tools/jpackage/share/AppImagePackageTest.java
Copyright

test/jdk/tools/jpackage/share/IconTest.java
Resolved @test block

test/jdk/tools/jpackage/share/LicenseTest.java
Copyright

test/jdk/tools/jpackage/share/MultiLauncherTwoPhaseTest.java
Resolved @test block

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8343314 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4016/head:pull/4016
$ git checkout pull/4016

Update a local copy of the PR:
$ git checkout pull/4016
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4016/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4016

View PR using the GUI difftool:
$ git pr show -t 4016

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4016.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 5, 2025 •
edited
Loading

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport e1b5f3c56d02c6738726106d3d069fea7a633245 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file Oct 5, 2025
@openjdk
Copy link

openjdk bot commented Oct 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 5, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 5, 2025 •
edited
Loading

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8343314 branch from 255253c to d71a1c2 Compare October 5, 2025 19:03
@openjdk
Copy link

openjdk bot commented Oct 5, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot mentioned this pull request Oct 5, 2025
Closed
4 tasks
schmelter-sap
schmelter-sap approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 9, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented Oct 9, 2025

Thanks for the review!

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 9, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 10, 2025

Going to push as commit ff3c3b4.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2025
@openjdk openjdk bot closed this Oct 10, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 10, 2025
@GoeLin GoeLin deleted the goetz_backport_8343314 branch October 10, 2025 09:15
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 10, 2025
@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@GoeLin Pushed as commit ff3c3b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@schmelter-sap schmelter-sap schmelter-sap approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GoeLin @schmelter-sap